This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/8] Add test for "layout asm"

From: Tom Tromey <tom at tromey dot com>
To: Andrew Burgess <andrew dot burgess at embecosm dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Fri, 26 Jul 2019 12:50:07 -0600
Subject: Re: [PATCH 2/8] Add test for "layout asm"
References: <20190721184910.26679-1-tom@tromey.com> <20190721184910.26679-3-tom@tromey.com> <20190726111130.GK23204@embecosm.com>

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> I noticed this pattern a lot in this series, I wonder if using
Andrew> 'gdb_assert' would be cleaner?

Thanks for mentioning this.  I wasn't aware of gdb_assert.

I've made this change and I'll send the new series momentarily.
I'd like to land this soon, because my next round of TUI refactorings is
about ready to send, and it needs the tests.

Tom

References:
- [PATCH 0/8] Testing for the TUI
  - From: Tom Tromey
- [PATCH 2/8] Add test for "layout asm"
  - From: Tom Tromey
- Re: [PATCH 2/8] Add test for "layout asm"
  - From: Andrew Burgess

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]