This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3][GDB][ARM]: gdb cannot step across CMSE secure entry function code.



> On 22 Jul 2019, at 16:58, Simon Marchi <simark@simark.ca> wrote:
> 
> Hi Srinath,
> 
> Just a formatting nit:
> 
>> +static CORE_ADDR
>> +arm_skip_cmse_entry (CORE_ADDR pc, const char *name, struct objfile *objfile)
>> +{
>> +  int target_len = strlen (name) + strlen ("__acle_se_") + 1;
>> +  char *target_name = (char *) alloca (target_len);
>> +  xsnprintf (target_name, target_len, "%s%s", "__acle_se_", name);
>> +
>> +  struct bound_minimal_symbol minsym
>> +   = lookup_minimal_symbol (target_name, NULL, objfile);
> 
> Missing one space here, before the equal.  No need to send a new version for this
> if everything else is fine, just make sure to fix it before pushing.
> 

I’ve pushed this on behalf of Srinath.


Thanks!
Alan.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]