This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2][GDB][ARM]: gdb cannot step across CMSE secure entry function code.


>>>>> "Srinath" == Srinath Parvathaneni <Srinath.Parvathaneni@arm.com> writes:

Srinath> I have incorporating all your review comments and sending a new
Srinath> patch here.

Thank you for the patch.

I have some trivial nits but otherwise nothing else.  I don't know much
about ARM but if Alan thinks it is ready to go in, then I agree :-)

Srinath> +  xsnprintf (target_name, target_len, "%s%s", "__acle_se_",name);

Should be a space after the "," before "name".

Srinath> +     && streq (sec->the_bfd_section->name,".gnu.sgstubs"))

Space after the "," here too.

Srinath> +  /* checks whether address pc holds belows to ".gnu.sgstubs" section.  */

Should be "Checks" -- i.e., upper cased.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]