This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix new-ui tty stream leak
- From: Simon Marchi <simark at simark dot ca>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Thu, 18 Jul 2019 16:09:21 -0400
- Subject: Re: [PATCH] Fix new-ui tty stream leak
- References: <20190718184124.21907-1-palves@redhat.com>
On 2019-07-18 2:41 p.m., Pedro Alves wrote:
> I noticed that we never close the stream opened by new-ui.
>
> This fixes it, by adding a new struct ui ctor that takes ownership of
> the passed-in stream.
Hi Pedro,
If I am not mistaken, we never delete the UIs themselves either, so it won't
make a difference today, is that right? They just live until the end of the
GDB process.
Still, I think this patch is fine, in that it makes things right in case we
decide to make it possible to close an existing UI some day.
Simon