This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 13/61] Introduce tui_data_window::delete_data_content_windows method

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Wed, 17 Jul 2019 12:26:34 -0600
Subject: Re: [PATCH 13/61] Introduce tui_data_window::delete_data_content_windows method
References: <20190704170311.15982-1-tom@tromey.com> <20190704170311.15982-14-tom@tromey.com> <4f12d3a2-cebc-3e36-58ae-ea95fb33b348@redhat.com>

Pedro> I noticed that the comment was copied to tui-data.h, and the original
Pedro> left behind, duplicated.  There are other cases in the patch, but 
Pedro> I saw this in other patches as well, but I did not think to point
Pedro> at all of them when I first read through the whole series (and then
Pedro> came back here).

Pedro> I'd drop "Function to" in the method's intro comments too, FWIW.

Pedro> Given the moving-code-around parts later in the series, it might
Pedro> be simpler to leave things as they are in these intermediate
Pedro> patches, not sure.

I went through the patches and updated them according to the above.

Tom

References:
- [PATCH 00/61] More TUI refactorings
  - From: Tom Tromey
- [PATCH 13/61] Introduce tui_data_window::delete_data_content_windows method
  - From: Tom Tromey
- Re: [PATCH 13/61] Introduce tui_data_window::delete_data_content_windows method
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]