This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 13/61] Introduce tui_data_window::delete_data_content_windows method


On 7/4/19 6:02 PM, Tom Tromey wrote:
> @@ -60,9 +60,9 @@ tui_data_window::first_data_item_displayed ()
>  /* Function to delete all the item windows in the data window.  This
>     is usually done when the data window is scrolled.  */
>  void
> -tui_delete_data_content_windows (void)
> +tui_data_window::delete_data_content_windows ()

I noticed that the comment was copied to tui-data.h, and the original
left behind, duplicated.  There are other cases in the patch, but 
I saw this in other patches as well, but I did not think to point
at all of them when I first read through the whole series (and then
came back here).

I'd drop "Function to" in the method's intro comments too, FWIW.

Given the moving-code-around parts later in the series, it might
be simpler to leave things as they are in these intermediate
patches, not sure.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]