This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix stepping bug associated with non-contiguous blocks


On Mon, 15 Jul 2019 09:21:26 -0600
Tom Tromey <tom@tromey.com> wrote:

> >>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:  
> 
> Kevin> gdb/ChangeLog:  
> 
> Kevin> 	* infrun.c (fill_in_stop_func): Use find_pc_partial_function
> Kevin> 	instead of find_function_entry_range_from_pc.  
> 
> Thanks for the explanation.  I think this makes sense.

Thanks for the review.

> Kevin> +	  ecs->stop_func_start
> Kevin> +	    += gdbarch_deprecated_function_start_offset (gdbarch);  
> 
> This hook is only used by VAX.  I wonder if we could delete it somehow.

I had to refresh my memory on what this was about.  On VAX, the CALL
instruction's target consists of a 16-bit entry mask followed by the
instructions that we'd normally expect to see.  The entry mask specifies
the registers which should be pushed (plus some other stuff too, I think.)

Do we still care about the VAX target?

If not, once the VAX target is deleted, that hook could be deleted too.

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]