This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Update breakpoint_1's documentation


Spotted a tiny typo.

On 7/10/19 2:51 AM, Simon Marchi wrote:

>  static int
> -breakpoint_1 (const char *args, int allflag, 
> +breakpoint_1 (const char *bp_num_list, bool show_internal,
>  	      int (*filter) (const struct breakpoint *))
>  {
>    struct breakpoint *b;
> @@ -6431,17 +6437,17 @@ breakpoint_1 (const char *args, int allflag,
>        if (filter && !filter (b))
>  	continue;
>  
> -      /* If we have an "args" string, it is a list of breakpoints to 
> +      /* If we have an "bp_num_list" string, it is a list of breakpoints to


The "an" should now be "a" now.

Maybe switch to UPPERCASE while at it:

 "have a BP_NUM_LIST string"

>  	 accept.  Skip the others.  */
> -      if (args != NULL && *args != '\0')
> +      if (bp_num_list != NULL && *bp_num_list != '\0')
>  	{


> @@ -6500,26 +6506,26 @@ breakpoint_1 (const char *args, int allflag,
>  	if (filter && !filter (b))
>  	  continue;
>  
> -	/* If we have an "args" string, it is a list of breakpoints to 
> +	/* If we have an "bp_num_list" string, it is a list of breakpoints to
>  	   accept.  Skip the others.  */
>  

Ditto.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]