This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/4] Prefer symtab symbol over minsym for function names in non-contiguous blocks
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org, Pedro Alves <palves at redhat dot com>
- Date: Wed, 3 Jul 2019 16:16:48 -0700
- Subject: Re: [PATCH 1/4] Prefer symtab symbol over minsym for function names in non-contiguous blocks
- References: <20190608195434.26512-1-kevinb@redhat.com> <20190608195434.26512-2-kevinb@redhat.com> <8f624a5d-58ba-8c6b-064d-9a82a63a6769@redhat.com> <87pnn05k50.fsf@tromey.com>
On Wed, 26 Jun 2019 11:30:51 -0600
Tom Tromey <tom@tromey.com> wrote:
> >> GDB is prefering this minsym over the the name provided by the
> >> DWARF info due to some really old code in GDB which handles
> >> "certain pathological cases". See the first big block comment
> >> in find_frame_funname for more information.
>
> Pedro> Yuck!
>
> >> I considered removing the code for this corner case entirely, but it
> >> seems as though it might still be useful, so I left it intact.
>
> Pedro> Yeah, I'd be inclined to try removing it too. The comment
> Pedro> smells of a.out or stabs limitations. But I'm not 100% sure,
> Pedro> and I'm sympathetic with forward incremental progress.
>
> That code dates to the creation of the sourceware repository.
>
> I think it could be deleted. And, if it's still a bug somehow, it seems
> better to fix it some other way, and not let stabs and/or a.out
> weirdness into the generic code.
Okay, for v2 of this patch series, I'll get rid of that code.
Thanks,
Kevin