This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] gdb: Remove a non-const reference parameter
- From: Simon Marchi <simark at simark dot ca>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Cc: Sergio Durigan Junior <sergiodj at redhat dot com>, Pedro Alves <palves at redhat dot com>
- Date: Tue, 2 Jul 2019 11:35:27 -0400
- Subject: Re: [PATCH] gdb: Remove a non-const reference parameter
- References: <20190629145820.GR23204@embecosm.com> <firstname.lastname@example.org>
On 2019-07-02 11:21 a.m., Andrew Burgess wrote:
> Non-const reference parameter should be avoided according to the GDB
> coding standard:
> This commit updates the gdbarch method gdbarch_stap_adjust_register,
> and the one implementation i386_stap_adjust_register to avoid using a
> non-const reference parameter.
> I've also removed the kfail from the testsuite for bug 24541, as this
> issue is now resolved.
So I was the one who added this rule to the guide. When I asked for opinions and
didn't get any, I thought it was because it wasn't very controversial and chose to add it.
Since then, Pedro mentioned a few times he didn't agree with it.
I'd like to know what others think, should we keep it (and enforce it) or remove it?