This is the mail archive of the
mailing list for the GDB project.
Re: ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output)
- From: Tom Tromey <tom at tromey dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Mon, 01 Jul 2019 11:20:25 -0600
- Subject: Re: ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output)
- References: <email@example.com> <firstname.lastname@example.org> <email@example.com> <firstname.lastname@example.org> <email@example.com> <firstname.lastname@example.org> <email@example.com> <firstname.lastname@example.org> <email@example.com> <firstname.lastname@example.org> <email@example.com> <firstname.lastname@example.org> <email@example.com> <firstname.lastname@example.org>
>>>>> "Pedro" == Pedro Alves <email@example.com> writes:
Pedro> The visual balance of brackets is appealing as well, so I can't say
Pedro> I have a strong preference either way. If you've been converting things
Pedro> already, you'll have a better judgment, so I'll defer to you.
I haven't really converted much, just what you saw on the branch.
I suspect using some kind of paired brackets will make it a little
harder to forget to close the style. But probably only a little. Also
I guess we could add asserts to check that the closing parameter is
Pedro> If we went the always-%pS way, I had written the patch and it'd
Pedro> look like this:
This is fine by me too.