This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/4] gdbserver: Add debug-file option

From: Tom Tromey <tom at tromey dot com>
To: Alan Hayward <Alan dot Hayward at arm dot com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
Date: Tue, 16 Apr 2019 13:39:48 -0600
Subject: Re: [PATCH 2/4] gdbserver: Add debug-file option
References: <20190416101729.16176-1-alan.hayward@arm.com> <20190416101729.16176-3-alan.hayward@arm.com>

>>>>> "Alan" == Alan Hayward <Alan.Hayward@arm.com> writes:

Alan> Add command line option to send all debug output to a given file.
Alan> Always default back to stderr.

Alan> Add matching monitor command. Add documentation.

Thanks.  The code parts of this are ok.

One little nit:

Alan> +  debug_file = fptr;
Alan> +  return;
Alan> +}

...this "return;" can be removed.

Tom

References:
- [PATCH 0/4] gdbserver/testsuite : Capture gdbserver debug output during testing
  - From: Alan Hayward
- [PATCH 2/4] gdbserver: Add debug-file option
  - From: Alan Hayward

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]