This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 5/8] Add aarch64 psuedo help functions

From: Pedro Alves <palves at redhat dot com>
To: Simon Marchi <simon dot marchi at ericsson dot com>, Alan Hayward <alan dot hayward at arm dot com>, gdb-patches at sourceware dot org
Cc: nd at arm dot com
Date: Thu, 31 May 2018 15:57:56 +0100
Subject: Re: [PATCH 5/8] Add aarch64 psuedo help functions
References: <20180511105256.27388-1-alan.hayward@arm.com> <20180511105256.27388-6-alan.hayward@arm.com> <680d01bb-e6ec-3d9e-e8a8-29d7c7bbf530@ericsson.com>

On 05/31/2018 01:06 PM, Simon Marchi wrote:

>> +/* Inner version of aarch64_pseudo_read_value.  */
>> +
>> +static struct value *
>> +aarch64_pseudo_read_value_2 (readable_regcache *regcache, int regnum_offset,
>> +			     int regsize, struct value *result_value)
> 
> It's not a big deal, but in other GDB parts we actually often use the _1 suffix
> for the helper functions.
> 

Also, I'd think "Helper for aarch64_pseudo_read_value." would be clearer,
because "inner version" sounds a bit odd to me.

> But otherwise, LGTM.

To me too.

Thanks,
Pedro Alves

References:
- [PATCH 0/8] Add SVE support for Aarch64 GDB
  - From: Alan Hayward
- [PATCH 5/8] Add aarch64 psuedo help functions
  - From: Alan Hayward
- Re: [PATCH 5/8] Add aarch64 psuedo help functions
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]