This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2][PR gdb/23210] Unset gdbarch significant_addr_bit by default
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Omair Javaid <omair dot javaid at linaro dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 29 May 2018 10:58:04 -0700
- Subject: Re: [PATCH v2][PR gdb/23210] Unset gdbarch significant_addr_bit by default
- References: <1527296331-32213-1-git-send-email-omair.javaid@linaro.org>
Hi Omar,
On Sat, May 26, 2018 at 05:58:51AM +0500, Omair Javaid wrote:
> This version fixes the typo and gdbarch.sh issue highlighted in review.
>
> LGTM?
>
> This patch fixes a bug introduced by fix to AArch64 pointer tagging.
>
> In our fix for tagged pointer support our agreed approach was to sign
> extend user-space address after clearing tag bits. This is not same
> for all architectures and this patch allows sign extension for
> addresses on targets which specifically set significant_addr_bit.
>
> More information about patch that caused the issues and discussion
> around tagged pointer support can be found in links below:
>
> https://sourceware.org/ml/gdb-patches/2018-05/msg00000.html
> https://sourceware.org/ml/gdb-patches/2017-12/msg00159.html
>
> gdb/ChangeLog:
>
> 2018-05-23 Omair Javaid <omair.javaid@linaro.org>
>
> * gdbarch.sh (significant_addr_bit): Default to zero when
> not set by target architecture.
> * gdbarch.c: Re-generated.
> * utils.c (address_significant): Update.
In addition to Pedro's comments, can you make sure you add "PR
gdb/23210" to the ChangeLog entry?
--
Joel