This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] gdb: Restore selected frame in print_frame_local_vars

From: Simon Marchi <simark at simark dot ca>
To: Andrew Burgess <andrew dot burgess at embecosm dot com>
Cc: gdb-patches at sourceware dot org
Date: Thu, 24 May 2018 10:10:14 -0400
Subject: Re: [PATCH] gdb: Restore selected frame in print_frame_local_vars
References: <20180519220831.14412-1-andrew.burgess@embecosm.com> <7b8e71b3-8913-07dc-9a0e-37e732c630c5@simark.ca> <20180522213331.GA3304@embecosm.com>

On 2018-05-22 17:33, Andrew Burgess wrote:

Simon,

Thanks for your feedback.  I've addressed most of your feedback in
this revision, there's a couple of points I've replied too inline.


Thanks, that LGTM.

Before pushing, can you add a small one line comment in the .exp (beforestandard_testfile) that says what the test does? I find it help gettingan idea of the purpose of the file without having to read through it.


Simon

References:
- [PATCH] gdb: Restore selected frame in print_frame_local_vars
  - From: Andrew Burgess
- Re: [PATCH] gdb: Restore selected frame in print_frame_local_vars
  - From: Simon Marchi
- Re: [PATCH] gdb: Restore selected frame in print_frame_local_vars
  - From: Andrew Burgess

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]