This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Fix macOS null pointer dereference
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Saagar Jha <saagar at saagarjha dot com>
- Date: Thu, 24 May 2018 13:44:07 +0100
- Subject: [PATCH] Fix macOS null pointer dereference
Saagar, could you give this a try?
<https://sourceware.org/bugzilla/show_bug.cgi?id=22960#c4> reports
that macOS gdb crashes with a null pointer dereference in
push_target(struct target_ops *). This commit fixes that.
The problem is that commit f6ac5f3d63e0 ("Convert struct target_ops to
C++") left the darwin_ops global uninitialized.
We don't need that global anymore, we can use the (new)
get_native_target function instead for the same effect.
gdb/ChangeLog:
yyyy-mm-dd Pedro Alves <palves@redhat.com>
* darwin-nat.c (darwin_ops): Delete.
(darwin_attach_pid): Use get_native_target.
---
gdb/darwin-nat.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c
index 0b1a4910a3..ed1ed32898 100644
--- a/gdb/darwin-nat.c
+++ b/gdb/darwin-nat.c
@@ -97,9 +97,6 @@ static void darwin_deallocate_exception_ports (darwin_inferior *inf);
static void darwin_setup_exceptions (struct inferior *inf);
static void darwin_deallocate_threads (struct inferior *inf);
-/* Target operations for Darwin. */
-static struct target_ops *darwin_ops;
-
/* Task identifier of gdb. */
static task_t gdb_task;
@@ -1656,6 +1653,7 @@ darwin_attach_pid (struct inferior *inf)
darwin_setup_exceptions (inf);
+ target_ops *darwin_ops = get_native_target ();
if (!target_is_pushed (darwin_ops))
push_target (darwin_ops);
}
--
2.14.3