This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 03/10] remote: Make readahead_cache a C++ class

From: Simon Marchi <simon dot marchi at ericsson dot com>
To: Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
Date: Fri, 18 May 2018 16:55:10 -0400
Subject: Re: [PATCH 03/10] remote: Make readahead_cache a C++ class
References: <20180516141830.16859-1-palves@redhat.com> <20180516141830.16859-4-palves@redhat.com>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99

On 2018-05-16 10:18 AM, Pedro Alves wrote:
> The idea here is eliminate the get_remote_state calls from within
> readahead_cache_invalidate, readahead_cache_invalidate_fd,
> remote_hostio_pread_from_cache by making those functions be class
> methods instead.  Later on we'll have one readahead_cache instance per
> remote connection, and this change makes that easier.

LGTM.

Simon

References:
- [PATCH 00/10] remote: More multi-target preparation
  - From: Pedro Alves
- [PATCH 03/10] remote: Make readahead_cache a C++ class
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]