Re: [RFA v2] Add "continue" response to pager

[Tom Tromey <tom at tromey dot com>]

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> I gave the patch a quick try, and I have to say that it looks a
Pedro> bit odd to me that the pager prompt takes two lines:

Pedro> ---Type <return> to continue, q <return> to quit, or c <return> to
Pedro>    continue without paging---

Pedro> I'm wondering whether we can shorten that, to, say:

Pedro> ---Type <return> for more, q to quit, c to continue without paging---

Yeah, I think that would be better.

The Emacs docs write <RET> for return.  So maybe:

Pedro> --Type <ret> for more, q to quit, c to continue without paging--       # 64 cols

Though I guess I would tend to add a couple of spaces, so:

-- Type <RET> for more, q to quit, c to continue without paging --       # 66 cols


I would like to get the spelling worked out before updating the patch.

Pedro> Did you look up the patch submission, see if it still makes sense?

Nope, but if we shorten the text then perhaps the change won't be
needed.

>> +static int pagination_disabled_for_command;

Pedro> Use bool?

I made this change locally.

Tom