This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 9/9] Add -Wimplicit-fallthrough
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Fri, 4 May 2018 19:34:32 +0100
- Subject: Re: [RFA 9/9] Add -Wimplicit-fallthrough
- References: <20180421183056.29292-1-tom@tromey.com> <20180421183056.29292-10-tom@tromey.com>
On 04/21/2018 07:30 PM, Tom Tromey wrote:
> This adds -Wimplicit-fallthrough to the set of default warnings.
>
> ../ChangeLog
> 2018-04-21 Tom Tromey <tom@tromey.com>
>
> * configure: Rebuild.
> * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough.
>
> ChangeLog
> 2018-04-21 Tom Tromey <tom@tromey.com>
>
> * configure: Rebuild.
Did you change your script to generate the ChangeLog's?
The paths in "../ChangeLog" and "ChangeLog" above look like
relative to gdb/gdbserver/, while I'd expect to see
gdb/ChangeLog and gdb/gdbserver/ChangeLog instead.
(Same throughout the series, but this one stood out.)
Thanks,
Pedro Alves