This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch][python] Consistently use $srcfile in py-breakpoint.exp
- From: Pedro Alves <palves at redhat dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 3 May 2018 18:06:04 +0100
- Subject: Re: [patch][python] Consistently use $srcfile in py-breakpoint.exp
- References: <57bc7a73-cfb0-a2b5-f873-c48875dd66d4@redhat.com>
On 04/30/2018 01:04 PM, Phil Muldoon wrote:
> This patch replaces py-breakpoint.exp's inconsistent use of string
> literals for source file name checks and replaces all instances
> with checks against $srcfile.
Nit: I think there's one "replaces" too many above. I think
something like this would be clearer:
This patch fixes py-breakpoint.exp's inconsistent use of both
string literals and $srcfile for source file name checks by
using $srcfile throughout.
OK with that fixed. Please push.
Thanks,
Pedro Alves