This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Change target_write_memory_blocks to use std::vector
- From: Tom Tromey <tom at tromey dot com>
- To: Simon Marchi <simark at simark dot ca>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Mon, 26 Feb 2018 12:37:56 -0700
- Subject: Re: [RFA] Change target_write_memory_blocks to use std::vector
- Authentication-results: sourceware.org; auth=none
- References: <20180225173703.6675-1-tom@tromey.com> <05afbce6-b052-9cb4-d4bc-c392f992ab60@simark.ca>
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> + load_section_data ()
>> + {
>> + }
Simon> Is this empty constructor needed?
I only added it for clarity. Is there some standard approach to this?
Or a gdb standard?
Simon> Actually, I think it would be nice to give constructors to the data
Simon> structures when possible, to make it less likely to have them in
Simon> invalid states.
Simon> Here's an example, you can integrate it in your patch if you like it.
Yeah, this seems better to me.
I will pull it in.
Tom