This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v7 0/2] Implement pahole-like 'ptype /o' option (and do some code reorg)
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: GDB Patches <gdb-patches at sourceware dot org>
- Cc: Tom Tromey <tom at tromey dot com>, Eli Zaretskii <eliz at gnu dot org>, Simon Marchi <simon dot marchi at ericsson dot com>, Pedro Alves <palves at redhat dot com>, Keith Seitz <keiths at redhat dot com>
- Date: Fri, 15 Dec 2017 15:11:42 -0500
- Subject: Re: [PATCH v7 0/2] Implement pahole-like 'ptype /o' option (and do some code reorg)
- Authentication-results: sourceware.org; auth=none
- References: <20171121160709.23248-1-sergiodj@redhat.com> <20171215011247.7396-1-sergiodj@redhat.com>
On Thursday, December 14 2017, I wrote:
> Changes from v6:
>
> - Updated examples in the documentation.
>
> - Removed stale comments about the test being x86_64-specific from
> tests.
>
> - Added tests for "ptype /oTM", "ptype /TMo", and for the regression
> Pedro caught.
>
> - Removed "print_offset_default_data".
>
> - Fixed regression reported by Pedro.
>
> - s/endpos/end_bitpos/
>
> - Filtered out the languages that don't implement the feature so that
> their type printing output doesn't get clobbered by "ptype /o" when
> they use "common" code (which is not actually common; it lives
> inside c-typeprint.c). I decided to do that by checking the current
> language on typeprint.c:whatis_exp, before setting the
> "print_offset" bit.
>
>
> The documentation parts have been approved by Eli, and haven't
> changed.
Patches have been pushed:
a27ed7d613ec91c3a79965d6bdab1fa96d559c85
7c1618381fdaa0697a211721ac31844f884797ac
Thanks for all the help with reviews and suggestions.
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/