This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: Fix ARI warnings in or1k-tdep.c
On Thu, Dec 14, 2017 at 06:51:06AM +0400, Joel Brobecker wrote:
> Hello,
>
> A very minor thing:
>
> > diff --git a/gdb/or1k-tdep.c b/gdb/or1k-tdep.c
> > index 54b365e958..06ee53e83c 100644
> > --- a/gdb/or1k-tdep.c
> > +++ b/gdb/or1k-tdep.c
> > @@ -132,7 +132,7 @@ or1k_analyse_inst (uint32_t inst, const char *format, ...)
> >
> > /* Check we got something, and if so skip on. */
> > if (start_ptr == end_ptr)
> > - error ("bitstring \"%s\" at offset %d has no length field.\n",
> > + error (_("bitstring \"%s\" at offset %d has no length field."),
> > format, i);
>
> The second line in the error looks over indented to me. I think
> it ought to be aligned with the other arguments on the first line:
>
> error (_("bitstring \"%s\" at offset %d has no length field."),
> format, i);
>
> (I think I saw about 3 instances of the same alignment issue)
Understood, I didnt notice those. Will fix, I have a few other patches to send.
-Stafford