This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Validate explicit locations with early termination

From: Keith Seitz <keiths at redhat dot com>
To: gdb-patches at sourceware dot org
Date: Thu, 7 Dec 2017 15:40:59 -0800
Subject: Re: [PATCH] Validate explicit locations with early termination
Authentication-results: sourceware.org; auth=none
References: <20171207212046.13452-1-keiths@redhat.com> <003824fa-c538-3f02-729f-8bf8192d51a5@ericsson.com>

On 12/07/2017 01:33 PM, Simon Marchi wrote:
hese two commands should have elicited the same error message.
>>
>> gdb/ChangeLog:
>>
>> 	PR breakpoints/22569
>> 	* location.c (string_to_explicit_location): When terminating
>> 	parsing early, break out of enclosing loop instead of returning.
>>
>> gdb/testsuite/ChangeLog:
>>
>> 	PR breakpoints/22569
>> 	* gdb.linespec/ls-errs.exp: Change expected result of "break
>> 	-source this file has spaces.c -line 3".
>> 	Check that an explicit source file followed by whitespace is
>> 	identified as an invalid explicit location.
> 
> This is quick customer support!  This patch fixes the reported issue
> and LGTM.

I'm just happy to see someone is using the explicit location feature, and as you can see from the patch, it was pretty trivial anyway.

Thank you for the quick review, this patch has been pushed, and I will close the bug.

Keith

References:
- [PATCH] Validate explicit locations with early termination
  - From: Keith Seitz
- Re: [PATCH] Validate explicit locations with early termination
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]