This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 5/6] Change Ada exceptions to use std::string

From: Tom Tromey <tom at tromey dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Thu, 30 Nov 2017 16:53:25 -0700
Subject: Re: [RFA 5/6] Change Ada exceptions to use std::string
Authentication-results: sourceware.org; auth=none
References: <20171130030140.14830-1-tom@tromey.com> <20171130030140.14830-6-tom@tromey.com> <20171130220348.cqv3ik5c2lie7xm5@adacore.com> <20171130225916.csgxhw2gcauyby6x@adacore.com>

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> (I tested my patch on x86_64-linux, limiting myself to gdb.ada)

Joel> Pb #1: Crash while trying to insert an assert catchpoint:

I wonder why I didn't see any problems from the buildbot.

Joel> Pb #3: condition handling in exception catchpoints is broken

Joel>     Tom removed a call to "skip_spaces" before checking for the next
Joel>     argument, and I am not sure I understand why.

Here I was confused and thought extract_arg skipped spaces again after
extracting the arg.  But, it doesn't.

Still - why not test failures?  This is disturbing.

Tom

References:
- [RFA 0/6] remove cleanups from Ada
  - From: Tom Tromey
- [RFA 5/6] Change Ada exceptions to use std::string
  - From: Tom Tromey
- Re: [RFA 5/6] Change Ada exceptions to use std::string
  - From: Joel Brobecker
- Re: [RFA 5/6] Change Ada exceptions to use std::string
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]