This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Define HAVE_NATIVE_GCORE_HOST on NetBSD
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: brobecker at adacore dot com (Joel Brobecker)
- Cc: n54 at gmx dot com (Kamil Rytarowski), jhb at FreeBSD dot org, gdb-patches at sourceware dot org
- Date: Fri, 24 Nov 2017 22:44:05 +0100 (CET)
- Subject: Re: [PATCH] Define HAVE_NATIVE_GCORE_HOST on NetBSD
- Authentication-results: sourceware.org; auth=none
Joel Brobecker wrote:
>
> > NetBSD ships with gcore(1) againg since the version 2.0.
> > This tool is functional and actively maintained.
> >
> > gdb/ChangeLog
> > 2017-09-05 Kamil Rytarowski <n54@gmx.com>
> >
> > * configure.nat: Define HAVE_NATIVE_GCORE_HOST on NetBSD.
>
> Makes sense. Approved.
This doesn't look right to me. Note that HAVE_NATIVE_GCORE_HOST
is not at all about whether there is some external gcore tool
provided by the OS. Rather, this flag defines whether the GDB
build should *provide* a gcore tool; if true, the GDB install
process provides a simple shell script called gcore that calls
GDB and runs the gcore command.
This only makes sense on platforms where GDB supports the gcore
command in the first place. This is not the case for GDB on
NetBSD as far as I can tell; the NetBSD native files do not
define any of the required callbacks.
What was the reason to add this define?
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com