This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 00/11] Remove some usages of find_inferior


On Friday, November 17 2017, Simon Marchi wrote:

> This is a random sampling of removals of find_inferior, replacing them with the
> new-ish find_thread/for_each_thread.

Thanks for the patch.  I looked over it, specifically the Linux-related
bits, and they seem fine.  Having hacked this code a bit on gdbserver
some time ago, I for one welcome this change.

> Simon Marchi (11):
>   Remove usage of find_inferior in win32-i386-low.c
>   Remove usage of find_inferior in win32-low.c
>   Remove usages of find_inferior in linux-arm-low.c
>   Remove usage of find_inferior in reset_lwp_ptrace_options_callback
>   Remove usage of find_inferior in iterate_over_lwps
>   Remove usage of find_inferior in unsuspend_all_lwps
>   Remove usage of find_inferior in linux_stabilize_threads
>   Remove usage of find_inferior when calling linux_set_resume_request
>   Remove usage of find_thread when calling resume_status_pending_p
>   Remove usages of find_thread when calling need_step_over_p
>   Remove usage of find_inferior when calling kill_one_lwp_callback
>
>  gdb/gdbserver/gdbthread.h      |  12 ++
>  gdb/gdbserver/linux-arm-low.c  |  55 +++++----
>  gdb/gdbserver/linux-low.c      | 248 ++++++++++++++---------------------------
>  gdb/gdbserver/win32-i386-low.c |  29 ++---
>  gdb/gdbserver/win32-low.c      |  12 +-
>  5 files changed, 137 insertions(+), 219 deletions(-)
>
> -- 
> 2.7.4

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]