This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 24/40] Per-language symbol name hashing algorithm
- From: Pedro Alves <palves at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 8 Nov 2017 16:08:40 +0000
- Subject: Re: [PATCH 24/40] Per-language symbol name hashing algorithm
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 84B0225C28
- References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-25-git-send-email-palves@redhat.com> <596E467A.9040401@redhat.com> <2138d07b-2aed-901d-9c96-9f8b728f22cb@redhat.com>
On 07/20/2017 07:53 PM, Pedro Alves wrote:
> On 07/18/2017 06:33 PM, Keith Seitz wrote:
>> On 06/02/2017 05:22 AM, Pedro Alves wrote:
>>>
>>> This patch starts fixing this, by doing two things:
>>>
>>> #1 - adds a language vector method to let each language decide how to
>>> compute a symbol name hash.
>>>
>>> #2 - makes dictionaries know the language of the symbols they hold,
>>> and then use the dictionaries language to decide which hashing
>>> method to use.
>>
>> Me likey! :-)
>>
>
> Ahah, it was your idea. :-)
>
>> Again, just the usual trivial comments.
>
> [snip]
>
> Thanks much. I added the missing comments now.
>
> Here's the updated patch.
FYI, I've pushed this one in now.
Thanks,
Pedro Alves