Re: [RFA 13/13] Use std::vector in h8300-tdep.c

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2017-11-02 18:36, Tom Tromey wrote:
> This changes h8300-tdep.c to use std::vector, allowing the removal of
> a cleanup.
>
> gdb/ChangeLog
> 2017-11-02  Tom Tromey  <tom@tromey.com>
>
> 	* h8300-tdep.c (h8300_push_dummy_call): Use std::vector.
> ---
>  gdb/ChangeLog    |  4 ++++
>  gdb/h8300-tdep.c | 16 ++++++----------
>  2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/gdb/h8300-tdep.c b/gdb/h8300-tdep.c
> index 011afcaba4..b9936c0283 100644
> --- a/gdb/h8300-tdep.c
> +++ b/gdb/h8300-tdep.c
> @@ -662,18 +662,16 @@ h8300_push_dummy_call (struct gdbarch *gdbarch,
> struct value *function,
>
>    for (argument = 0; argument < nargs; argument++)
>      {
> -      struct cleanup *back_to;
>        struct type *type = value_type (args[argument]);
>        int len = TYPE_LENGTH (type);
>        char *contents = (char *) value_contents (args[argument]);
>
>        /* Pad the argument appropriately.  */
>        int padded_len = align_up (len, wordsize);
> -      gdb_byte *padded = (gdb_byte *) xmalloc (padded_len);
> -      back_to = make_cleanup (xfree, padded);
> +      std::vector<gdb_byte> padded (padded_len);

I would suggest adding a comment that std::vector is used (and not 
gdb::byte_vector) because we want it to be zero-ed out.  Otherwise 
someone will feel the urge to change it to gdb::byte_vector some day :).

Simon