This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Use SaL symbol name when reporting breakpoint locations
- From: Keith Seitz <keiths at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Fri, 27 Oct 2017 10:59:55 -0700
- Subject: Re: [PATCH v2] Use SaL symbol name when reporting breakpoint locations
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=keiths at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C3BE5C057FA1
- References: <20171020185101.1736-1-keiths@redhat.com> <7255ffd0-8ff6-efe1-9763-e82a9a301cf3@redhat.com>
On 10/27/2017 07:32 AM, Pedro Alves wrote:
> On 10/20/2017 07:51 PM, Keith Seitz wrote:
>
>> +
>> + if {$source != ""} {
>> + set source "/$source:$line"
>
> I suspect this '/' breaks with remote host testing. See e.g.,:
> https://sourceware.org/ml/gdb-patches/2013-04/msg00088.html
Thank you for pointing that out. I did not remember that. [I really need to set up a remote host testing environment here!]
It makes no difference to the test if the '/' is in there (when `source' is added to the final regexp return by this procedure, it is preceded with ".*", so it makes no difference). As in the referenced message/patch, I've removed that character.
> Otherwise LGTM.
Pushed with that change, thank you again!
Keith