This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Use SaL symbol name when reporting breakpoint locations


On 10/27/2017 07:32 AM, Pedro Alves wrote:
> On 10/20/2017 07:51 PM, Keith Seitz wrote:
> 
>> +
>> +    if {$source != ""} {
>> +	set source "/$source:$line"
> 
> I suspect this '/' breaks with remote host testing.  See e.g.,:
> https://sourceware.org/ml/gdb-patches/2013-04/msg00088.html

Thank you for pointing that out. I did not remember that. [I really need to set up a remote host testing environment here!]

It makes no difference to the test if the '/' is in there (when `source' is added to the final regexp return by this procedure, it is preceded with ".*", so it makes no difference). As in the referenced message/patch, I've removed that character.

> Otherwise LGTM.

Pushed with that change, thank you again!

Keith


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]