This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Merge/shared string_printf and string_vprintf unit tests
- From: John Baldwin <jhb at freebsd dot org>
- To: gdb-patches at sourceware dot org
- Cc: Pedro Alves <palves at redhat dot com>
- Date: Wed, 18 Oct 2017 10:40:18 -0700
- Subject: Re: [PATCH] Merge/shared string_printf and string_vprintf unit tests
- Authentication-results: sourceware.org; auth=none
- References: <1508194677-19549-1-git-send-email-palves@redhat.com>
On Monday, October 16, 2017 11:57:57 PM Pedro Alves wrote:
> Merge the string_printf and string_vprintf tests, running them all
> against both functions.
>
> gdb/ChangeLog:
> 2017-10-16 Pedro Alves <palves@redhat.com>
>
> * unittests/common-utils-selftests.c (format_func): New typedef.
> (string_printf_tests, string_vprintf_tests): Tests factored out
> and merged to ...
> (test_format_func): ... this new function.
> (string_printf_tests, string_vprintf_tests): Reimplement on top of
> test_format_func.
Looks good to me.
--
John Baldwin