Re: [pushed 8.0-branch] [Bug server/22137] gdbserver crashes on hosts with pkru register

[Pedro Alves <palves at redhat dot com>]

On 10/16/2017 02:20 PM, Tedeschi, Walfred wrote:
> 
>>> > > I also couldn't compile master:
>>> > > ../../../binutils-gdb/gdb/probe.c: In function \u2018void
>> > parse_probes_in_pspace(const probe_ops*, program_space*, const char*,
>> > const char*, const char*, std::vector<symtab_and_line>*)\u2019:
>>> > > ../../../binutils-gdb/gdb/probe.c:68:12: error: types may not be defined in a
>> > for-range-declaration [-Werror]
>>> > >        for (struct probe *probe : probes)
>>> > >             ^~~~~~
>>> > > ../../../binutils-gdb/gdb/probe.c: In function \u2018VEC_probe_p*
>> > find_probes_in_objfile(objfile*, const char*, const char*)\u2019:
>>> > > ../../../binutils-gdb/gdb/probe.c:213:8: error: types may not be defined in a
>> > for-range-declaration [-Werror]
>>> > >    for (struct probe *probe : probes)
>>> > >         ^~~~~~
>>> > >
>>> > > Are you aware of it?
>> > 
>> > Yes, it's a GCC bug:
>> >  https://sourceware.org/ml/gdb-patches/2017-09/msg00270.html
>> > 
>> > What is your gcc version?
>> > 
>> > I don't see this myself, but I know that Keith also ran into this recently.  If it's
>> > easy to work around it, I don't see why not.
>> > 
>> > Does this work for you?
>> > 
> It worked!

Thanks, I'll push in a bit.  I'm still curious to 
know your gcc version though.

Actually, I'm confused on how it worked for you, since
I hadn't fixed the same problem around line "213" quoted
above.

Are you sure you tested with the same compiler?

Thanks,
Pedro Alves