This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[pushed] Make gdb.base/solib-nodir.exp work with --target_board=native-extended-gdbserver
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Fri, 13 Oct 2017 10:37:00 +0100
- Subject: [pushed] Make gdb.base/solib-nodir.exp work with --target_board=native-extended-gdbserver
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BDD4881DF8
Fixes:
Running .../src/gdb/testsuite/gdb.base/solib-nodir.exp ...
FAIL: gdb.base/solib-nodir.exp: library loaded
... by using the new "set cwd" command.
gdb/testsuite/ChangeLog:
2017-10-13 Pedro Alves <palves@redhat.com>
Simon Marchi <simon.marchi@polymtl.ca>
* gdb.base/solib-nodir.exp: Split is_remote and skip_shlib_tests
calls and add comments. Skip test if use_gdb_stub is set.
(top level): Use "set cwd" command instead of "cd" command.
---
gdb/testsuite/ChangeLog | 7 +++++++
gdb/testsuite/gdb.base/solib-nodir.exp | 18 +++++++++++++++---
2 files changed, 22 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 9aac613..b37da2a 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,4 +1,11 @@
2017-10-13 Pedro Alves <palves@redhat.com>
+ Simon Marchi <simon.marchi@polymtl.ca>
+
+ * gdb.base/solib-nodir.exp: Split is_remote and skip_shlib_tests
+ calls and add comments. Skip test if use_gdb_stub is set.
+ (top level): Use "set cwd" command instead of "cd" command.
+
+2017-10-13 Pedro Alves <palves@redhat.com>
* gdb.base/shlib-call.exp (top level): Use gdb_run_cmd and remove
is_remote target check.
diff --git a/gdb/testsuite/gdb.base/solib-nodir.exp b/gdb/testsuite/gdb.base/solib-nodir.exp
index 9cb682e..15673d1 100644
--- a/gdb/testsuite/gdb.base/solib-nodir.exp
+++ b/gdb/testsuite/gdb.base/solib-nodir.exp
@@ -13,8 +13,19 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>. */
-# are we on a target board
-if {[is_remote target] || [skip_shlib_tests]} {
+if [skip_shlib_tests] {
+ return
+}
+
+# The testcase assumes the target can access the OBJDIR.
+if [is_remote target] {
+ return
+}
+
+# We need to be able to influence the target's environment and working
+# directory. Can't do that if when we connect the inferior is already
+# running.
+if [target_info exists use_gdb_stub] {
return
}
@@ -44,7 +55,8 @@ clean_restart $executable
gdb_load_shlib ${binlibfile}
gdb_test_no_output "set env LD_LIBRARY_PATH=:"
-gdb_test "cd ${binlibfiledir}" "Working directory [string_to_regexp ${binlibfiledir}]\\." "cd OBJDIR/${subdir}"
+gdb_test_no_output "set cwd ${binlibfiledir}" \
+ "set cwd OBJDIR/${subdir}"
set test "library loaded"
if [runto_main] {
--
2.5.5