This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/4] BFD: Extract PID from MIPS core dump file


On Fri, 6 Oct 2017, Djordje Todorovic wrote:

> Please notice that I have corrected the offset for MIPS o32 and MIPS n32 from
> the first iteration.

 Yes, thanks.

> On MIPS o32, n32 and n64 platforms, PID information was not
> correctly propagated from core dump file to internal GDB
> structures. This patch fixes that behavior.

 Two spaces after a full stop please.  It would be good to mention in the 
commit description what the consequence (symptom) of the bug was.

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]