This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] GDB test suite: Add helper for locating core files
- From: Pedro Alves <palves at redhat dot com>
- To: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>, Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 12 Oct 2017 14:47:19 +0100
- Subject: Re: [PATCH 1/2] GDB test suite: Add helper for locating core files
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AF373D7812
- References: <1505760152-28775-1-git-send-email-arnez@linux.vnet.ibm.com> <1505760152-28775-2-git-send-email-arnez@linux.vnet.ibm.com> <20171007094545.1bba5c51@pinnacle.lan> <m31smcp3b6.fsf@oc1027705133.ibm.com>
On 10/09/2017 07:46 PM, Andreas Arnez wrote:
> @@ -5883,7 +5883,7 @@ proc run_and_get_core {binfile {arg ""}} {
> # specified. Return that path name, or "" if no core file was found.
>
> proc find_core {binfile coredir {destcore ""}} {
> - if {[is_remote target]} {
> + if {![isnative]} {
> warning "Can not access remote core file."
> return ""
> }
This seems incorrect to me. "isnative" only checks
if the build and target _triplets_ are the same. So
foo-linux-gnu gdb x foo-linux-gnu gdbserver on separate
machine still returns isnative==true.
I think the real problem is that the native-gdbserver board
returns true to is_remote, when I think it shouldn't.
Doing that alone results in fallout in the testsuite, of
course. I'm seeing if fixing it is doable.
Thanks,
Pedro Alves