This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Re: Flash memory size not aligned to address

On 10/11/2017 04:53 PM, Kevin Buettner wrote:

> I gather it too late to amend it now, right?  (Since git commit --amend
> only works on the most recent commit.)

Right, it's too late, but the reason is we don't allow history
rewrites of the upstream repo; we only allow fast-forward merges
to keep history linear -- even if it were the most recent commit,
you wouldn't be able to push it.  (And it's possible to amend
more than one commit.)  The closest would be to revert the patch, and
reapply the original patch with author fixed.  (Not sure it's
worth complicating git history a bit, but it's easy enough to
do if desired.)

Thanks,
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]