This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Constify add_prefix_cmd
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Wed, 11 Oct 2017 13:57:28 +0100
- Subject: Re: [RFA] Constify add_prefix_cmd
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D6B46C059B72
- References: <20171010193206.21072-1-tom@tromey.com>
On 10/10/2017 08:32 PM, Tom Tromey wrote:
> Note that this touches a couple of files (gnu-nat.c and go32-nat.c)
> that I can't build.
I tried compiling go32-nat.c with a cross compiler I have
handy, and it compiles fine. (the djgpp build is broken for
other reasons, though. I fixed one problem today, but
not all [1].)
I don't have a Hurd cross-compiler setup handy, but the
change looks fine, and it's not like it'd be hard to
fix if it turned out incomplete.
[1] - https://sourceware.org/ml/binutils/2017-10/msg00167.html
Patch is OK.
Thanks,
Pedro Alves