This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 00/12] some minor cleanup removals
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>, Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 28 Sep 2017 23:11:07 +0100
- Subject: Re: [RFA 00/12] some minor cleanup removals
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 947EE4E4C3
- References: <20170928195011.27382-1-tom@tromey.com> <87poaalelw.fsf@redhat.com>
On 09/28/2017 10:04 PM, Sergio Durigan Junior wrote:
> On Thursday, September 28 2017, Tom Tromey wrote:
>
>> This removes a number of cleanups, generally string related.
>>
>> I introduced string_vprintf to allow the use of std::string in some of
>> these patches.
>>
>> The final patch just removes a couple of unused declarations; I would
>> have checked it in as obvious, but it was more convenient to just
>> leave it in this series.
>
> FWIW, I looked at the patches and they seem OK to me.
>
> Thanks for doing all these cleanups!
Seconded!
I sent a few comments, but overall it looks good to me too.
Thanks,
Pedro Alves