Re: [RFA] Remove make_cleanup_restore_target_terminal

[Pedro Alves <palves at redhat dot com>]

On 09/21/2017 05:06 PM, Tom Tromey wrote:
> Simon> Clang gives this warning, which seems valid to me:
> 
> Sorry about this.
> 
> Pedro> Indeed.  The field should be a scoped_restore_tmpl instead of
> Pedro> a scoped_restore, and that mem-initializer above should be
> Pedro> calling the scoped_restore_tmpl ctor instead of make_scoped_restore.
> 
> How's the appended?
> 
> commit c068483d29873c3bc80c8accc3f50cecae0f33d8
> Author: Tom Tromey <tom@tromey.com>
> Date:   Thu Sep 21 09:54:25 2017 -0600
> 
>     Change type of scoped_input_handler::m_quit_handler
>     
>     Simon pointed out that scoped_input_handler::m_quit_handler must have
>     the correct scoped_restore_tmpl type, to avoid binding to a temporary.
>     This patch fixes the problem.
>     
>     gdb/ChangeLog
>     2017-09-21  Tom Tromey  <tom@tromey.com>
>     
>             * utils.c (class scoped_input_handler) <m_quit_handler>: Change
>             type to scoped_restore_tmpl.
>             <scoped_input_handler>: Initialize m_quit_handler directly.

Reviewed-by: Pedro Alves <palves@redhat.com>

Thanks,
Pedro Alves