This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 38/67] Constify some linespec functions
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Thu, 21 Sep 2017 11:04:01 +0100
- Subject: Re: [RFA 38/67] Constify some linespec functions
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 48CEA4E334
- References: <20170921051023.19023-1-tom@tromey.com> <20170921051023.19023-39-tom@tromey.com>
On 09/21/2017 06:09 AM, Tom Tromey wrote:
In several places you followed a pattern like:
> static void
> -foo_command (char *args, int from_tty)
> +foo_command (char *args_in, int from_tty)
... and then args_in wasn't used.
I'd be nice to mention in the commit log the reason for this.
I assume that it's because we don't have the corresponding
constified add_cmd variant?
Thanks,
Pedro Alves