This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] icc: allow code path for newer versions of icc.




On 09/18/2017 09:13 PM, Simon Marchi wrote:
On 2017-09-18 17:31, Tedeschi, Walfred wrote:
I am considering sending then two patches:
1. Add things in utils.c
2. move all producers to a new producers.h/c file.

Would this be ok?

(I am just speaking for myself)

I usually prefer the opposite, cleanup first then add new features (because sometimes the cleanup is promised and never comes :)), but really I'm fine with both. The fact that you are ready to do some cleanup is appreciated.

Simon
Hello Simon and Pedro,

I have prepared a cleaning patch first and another one with the icc version check.

The changes are in:
users/wtedesch/icc_version

Comments are welcome!

Thanks and regards,
/Fred
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]