This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] Add a 'starti' command.
- From: Pedro Alves <palves at redhat dot com>
- To: John Baldwin <jhb at freebsd dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 19 Sep 2017 19:29:08 +0100
- Subject: Re: [PATCH v3] Add a 'starti' command.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9C9B77F3E5
- References: <20170911220803.73819-1-jhb@FreeBSD.org> <7b165874-88ec-0ef2-50c5-9eb7b19eeb53@redhat.com> <19338806.QVLJa9ilSl@ralph.baldwin.cx>
On 09/19/2017 06:49 PM, John Baldwin wrote:
> Hmm, how about:
>
> enum run_how
> {
> /* Run program without any explicit stop during startup. */
> RUN_NORMAL,
Sounds fine.
>> You have a "\n" in the middle of some lines above. Was that intended?
>> I'd expect to see instead lines broken at \n, ending with \n\ .
>
> Those were just copy and pasted from the run help. I think they were there
> to avoid overflowing 80 columns in the source. I've rewrapped the text so
> that newlines are at the end.
Thanks.
>> Space before parens, line break after return type.
>> We follow GNU convention in tests too, unless different syntax is
>> relevant for the test.
>
> Ok. (Ironically I copied both the spurious #include and bad style
> from start.c.)
Yeah, sorry about that. It was only in recent years that we
started following that rule; older tests will be using
random styles.
Thanks,
Pedro Alves