This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Use "switch_to_thread" more thoroughly on gdbserver
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Fri, 15 Sep 2017 12:14:38 +0100
- Subject: Re: [PATCH] Use "switch_to_thread" more thoroughly on gdbserver
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E52C17E422
- References: <20170915043357.26094-1-sergiodj@redhat.com>
On 09/15/2017 05:33 AM, Sergio Durigan Junior wrote:
> diff --git a/gdb/gdbserver/target.c b/gdb/gdbserver/target.c
> index 752646310a..2226dc802d 100644
> --- a/gdb/gdbserver/target.c
> +++ b/gdb/gdbserver/target.c
> @@ -26,14 +26,11 @@ struct target_ops *the_target;
> int
> set_desired_thread (int use_general)
> {
> - struct thread_info *found;
> -
> if (use_general == 1)
> - found = find_thread_ptid (general_thread);
> + switch_to_thread (general_thread);
> else
> - found = find_thread_ptid (cont_thread);
> + switch_to_thread (cont_thread);
>
> - current_thread = found;
> return (current_thread != NULL);
Did you double-check whether this is equivalent? Off hand, I'd
think it is, but the minus_one_ptid check in switch_to_thread
gave me pause. there's a 'set_continue_thread (minus_one_ptid)' in
gdb in early connection setup. Looks like we never call
'set_desired_thread(0)' nowadays though. [Hc predates vCont].
Do you remember why that check is there in switch_to_thread in the
first place, as opposed to, say, an assertion?
Thanks,
Pedro Alves