Re: [PATCH 0/4] New "set cwd" command

[Pedro Alves <palves at redhat dot com>]

On 09/12/2017 05:23 AM, Sergio Durigan Junior wrote:
> This patch series is a followup of the discussion that happened at:
> 
>   https://sourceware.org/ml/gdb-patches/2017-09/msg00160.html
> 
> It implements a new GDB command, "set cwd", which is used to set the
> current working directory of the inferior that will be started.  This
> is a GDB-only command for now; its gdbserver counterpart will come
> later.

I think I'd prefer that the gdbserver counterpart was included
as part of the same series.  I.e., I'd like to see the gdbserver
side explored first before we change the native side and commit
to the commands/interface.  Also, I think that would help make
sure that the manual documentation is adjusted in a way that
naturally reads as applying to local and remote.

For example, we currently say

 "Each time you start your program with @code{run}, it inherits its 
 working directory from the current working directory of
 @value{GDBN}.", 

but you didn't change that particular sentence, which seems to leave
it a bit incorrect.  I think we should say instead say that
when you start your program with run, the inferior starts with
the directory specified by "set cwd", and then mention that
if that is not set, then the inferior inherits gdb's current
directory if native debugging, and gdbserver's if remote debugging.
Right?

Thanks,
Pedro Alves