This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add DISABLE_COPY_AND_ASSIGN
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Pedro Alves <palves at redhat dot com>, Yao Qi <qiyaoltc at gmail dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Sat, 9 Sep 2017 20:45:39 +0200
- Subject: Re: [PATCH] Add DISABLE_COPY_AND_ASSIGN
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon dot marchi at ericsson dot com;
- References: <1500385686-19857-1-git-send-email-yao.qi@linaro.org> <179e2d35-d903-1d6d-256a-063a35d677d2@redhat.com> <86iniprd5l.fsf@gmail.com> <075e7089-199f-f251-c4a2-58099b5f06e9@redhat.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 2017-07-18 05:38 PM, Pedro Alves wrote:
>
> On 07/18/2017 04:13 PM, Yao Qi wrote:
>> Pedro Alves <palves@redhat.com> writes:
>>
>>> Yes, please. I've been meaning to add something like this for a while.
>>>
>>> IMO, this could go in include/ansidecl.h, with a fallback version for
>>> #if __cplusplus < C++11 that declares the methods without =delete (you
>>> get a link error instead).
>>>
>>
>> I thought about adding this into include/, but can't find the right
>> file. I'll move the macro to include/ansidecl.h.
>
> Thanks. Note that that file is maintained by gcc.
>
>>
>>>> /* Pull in gdb::unique_xmalloc_ptr. */
>>>> #include "common/gdb_unique_ptr.h"
>>>>
>>>> +#define DISABLE_COPY_AND_ASSIGN(TYPE) \
>>>> + TYPE (const TYPE&) = delete; \
>>>> + void operator= (const TYPE &) = delete;
>>>> +
>>>
>>> Should this have an intro comment?
>>>
>>
>> I thought it is too simple to have a comment :) How about this?
>>
>> /* A macro to disable the copy constructor and assignment operator.
>> When building with C++ 11, explicitly delete these methods.
>> Otherwise, place this macro in the private: declarations of a class. */
>
> How about this tweak:
>
> /* A macro to disable the copy constructor and assignment operator.
> When building with C++11 and above, the methods are explicitly
> deleted, causing a compile-time error if something tries to copy.
> For C++03, this just declares the methods, causing a link-time
> error if the methods end up called (assuming you don't
> define them). For C++03, for best results, place the macro
> under the private: access specifier, so that most attempts at
> copy are caught at compile-time. */
>
> Thanks,
> Pedro Alves
>
Hi Yao,
Out of curiosity, did you make any progress on this?
Thanks,
Simon