Re: [PATCH v2] Define an error function in the PPC simulator library.

[John Baldwin <jhb at FreeBSD dot org>]

On 9/4/17 7:19 AM, Pedro Alves wrote:
> On 04/13/2017 06:18 PM, John Baldwin wrote:
>> On Thursday, April 13, 2017 08:25:27 AM Luis Machado wrote:
>>> On 04/05/2017 11:33 AM, John Baldwin wrote:
>>>> Previously this used the error function from GDB directly when linked
>>>> against GDB instead of the error method in the host callbacks
>>>> structure.  This was exposed via a link error when GDB was converted
>>>> to C++.  The error function invokes the error callback similar to
>>>> sim_io_error.
>>>>
>>>
>>> There is another implementation of error (...) in sim/ppc/main.c and 
>>> sim/ppc/misc.c. Should those be kept as is or should we only use the new 
>>> function you're providing?
>>
>> My understanding is that they should be kept as-is.  This file is only used
>> when linking the library against GDB (and actually, rereading the log message,
>> I should reword the opening sentence to make this clearer).  sim-calls.o isn't
>> included in the actual library.  Each consumer of the library is required
>> to export a couple of symbols that libsim.a uses including "error".  The dgen,
>> igen, tmp-filter, tmp-ld-decode, tmp-ld-cache, and tmp-ld-insn programs use
>> the functions from misc.c.  psim uses the functions from main.c, and
>> GDB uses the functions from sim-calls.o.
> 
> It'd be nice to include this info somewhere, likely in the commit log.

Will do.  Is there still time to merge this into 8.0.1 (and if so, can you
approve it)?

Thanks!

-- 
John Baldwin