This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/3] Add tests for loop_break and loop_continue commands

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Pedro Alves <palves at redhat dot com>
Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
Date: Mon, 04 Sep 2017 19:15:49 +0200
Subject: Re: [PATCH 3/3] Add tests for loop_break and loop_continue commands
Authentication-results: sourceware.org; auth=none
References: <1504388179-579-1-git-send-email-simon.marchi@ericsson.com> <1504388179-579-4-git-send-email-simon.marchi@ericsson.com> <3fad43f4-0969-4d11-a361-1ba48d856c2e@redhat.com>

On 2017-09-04 14:36, Pedro Alves wrote:

On 09/02/2017 10:36 PM, Simon Marchi wrote:

I grepped the testsuite for loop_break and loop_continue and didn'tfind

anything, so I wrote some simple tests for those.

gdb/testsuite/ChangeLog:

	* gdb.base/commands.exp: Call the new procedures.
	(loop_break_test, loop_continue_test): New procedures.


LGTM, please push, and thanks for doing this.

I do wonder whether we handle loop_break/loop_continue in nested
loops correctly though, since the tests don't seem to
exercise that.

Thanks,
Pedro Alves

Ah good point. I am pushing this one, and I'll work on another patch totest this.


Thanks,

Simon

References:
- [PATCH 0/3] Tiny patches related to command lines
  - From: Simon Marchi
- [PATCH 3/3] Add tests for loop_break and loop_continue commands
  - From: Simon Marchi
- Re: [PATCH 3/3] Add tests for loop_break and loop_continue commands
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]