This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 26 Aug 2017 15:53:58 -0400
- Subject: Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9777BC04B936
- References: <E1dlPHW-0007LM-Eg@kwanyin.sergiodj.net> <20170826123906.wg5s7qsm65lklk5s@adacore.com>
On Saturday, August 26 2017, Joel Brobecker wrote:
> Hello,
>
> On Fri, Aug 25, 2017 at 08:48:58PM -0400, gdb-buildbot@sergiodj.net wrote:
>> My lords, ladies, gentlemen, members of the public.
>>
>> It is a matter of great regret and sadness to inform you that commit:
>>
>> remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type
>> 988f6b3dc615173d6d78a76ac26c109b4582da74
>>
>> might have made GDB unwell. Since I am just your Butler BuildBot,
>> I kindly ask that a human superior officer double-check this.
>
> My change only touches a static function in ada-lang.c, while
> the error is reported inside sparc64-tdep. Maybe an earlier commit?
Yeah, sorry about these messages. BuildBot is currently not smart
enough to figure out that the failure was not introduced by the last
commit. One solution, proposed by Pedro, is to send the breakage e-mail
to the authors of all commits that haven't been tested until the last
one, but that's also not easy to do... I'll investigate and see if
there's any other way.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/