This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Remove save_inferior_ptid
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 18 Aug 2017 11:24:55 +0100
- Subject: Re: [RFA] Remove save_inferior_ptid
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4FD4CC0587C7
- References: <20170817024601.25136-1-tom@tromey.com> <1cc87d09-8538-341b-0976-98f35a02edc0@redhat.com> <87efs9k415.fsf@tromey.com>
On 08/18/2017 03:23 AM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> Did you try that? Patch #1 below runs regression free here. How about
> Pedro> putting that in first, avoiding reindenting the big block around twice?
>
> I didn't think of it, but I ran this through the buildbot and it seems fine.
>
> Pedro> That leaves linux_get_siginfo_data. Since this is a local
> Pedro> static function, it's easy to pass the thread as argument, pushing
> Pedro> the inferior_ptid switching further down. See attached patch #2.
> Pedro> WDYT?
>
> Good idea.
>
> Here's the new patch.
LGTM.
Thanks,
Pedro Alves