This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 3/7] Documentation for gdb.thread_from_thread_handle
- From: Kevin Buettner <kevinb at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 18 Jul 2017 17:13:00 -0700
- Subject: Re: [PATCH v2 3/7] Documentation for gdb.thread_from_thread_handle
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kevinb at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 97DD43D94D
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 97DD43D94D
- References: <20170408224959.67164a27@pinnacle.lan> <20170408230700.3754771e@pinnacle.lan> <d0448ba9b954ef3cba07228d3b6c71ed@polymtl.ca>
On Fri, 05 May 2017 00:01:31 -0400
Simon Marchi <simon.marchi@polymtl.ca> wrote:
> > +@defun gdb.thread_from_thread_handle (thread_handle)
> > +Return the thread object corresponding to the thread handle,
> > +@var{thread_handle}, a thread library specific data structure such as
>
> The comma before @var{thread_handle} feels unnecessary. And I think you
> could shorten it to "... corresponding to @var{thread_handle}, ..."
> without loss of clarity.
I like your proposed (re)wording. Since it's okay with Eli, that's
what I've incorporated into the new patch which I will post shortly.
Kevin